search

bitwalker / toml-elixir

An implementation of TOML for Elixir projects, compliant with the latest specification
Apache License 2.0
202 stars 24 forks source link

Persist configs after merging #25

Closed jeffweiss closed 4 years ago

jeffweiss commented 4 years ago

Prior to this commit when using the Toml.Provider as a Distillery config provider with Elixir 1.9+, configuration changes made in the corresponding .toml files were not reflected in the running application. This commit adds a call to Application.put_all_env after deep-merging the configurations to ensure that the merge is available to all processes afterwards.

Co-authored-by: Jed Schneider jed.schneider@gmail.com Co-authored-by: Brent Yoder brent.yoder@testdouble.com Co-authored-by: Greg Baraghimian greggreg@gmail.com

Fixes #23

ijunaid8989 commented 4 years ago

all these 3 people co-authored these 3 lines?

bitwalker commented 4 years ago

@ijunaid8989 I'm guessing it was a pair programming session where all three were present, hence all being considered co-authors of the change :)

ijunaid8989 commented 4 years ago

@bitwalker thanks for the information :) and I think you are right.

jeffweiss commented 4 years ago

@ijunaid8989 Yes, we were mobbing on trying to figure out why our upgrade to distillery 2.x and migration from conform to toml was failing to pick up configuration changes after installation of the release. So, yeah, this patch represents half a day of four people's time.