search

bitwarden / android

Bitwarden mobile app for Android.
https://bitwarden.com
GNU General Public License v3.0
6.52k stars 818 forks source link

Auto fill not working properly on some apps #159

Closed jerryn70 closed 3 years ago

jerryn70 commented 7 years ago

When I click on the matching result bitwarden is not filling the password fields. But then if I click username box and then click again the password box it will autofil.

Steps :

1, Open Myntra app 2, Clicked password field 3, Bitwarden notification shows 4, Typed pin and shows correct matching result 5, Clicked matching result 6, Nothing happens. 7, Clicked username name field and then again clicked password field. 8, It got auto filled .

Auto fill method : password field focused Android version 7.1.1 Bitwarden version : 1.12.1

Apps that I found this issue

1, https://play.google.com/store/apps/details?id=com.myntra.android

2, https://play.google.com/store/apps/details?id=com.flipkart.android

jerryn70 commented 7 years ago

This same issue is occurring on some other apps and websites also. Early this apps and websites were worked fine with autofil. I think this issues started from the latest Bitwarden version.

kspearrin commented 7 years ago

Not sure whats going on here, but it worked just fine for me. See

ezgif com-video-to-gif 2 ezgif com-video-to-gif 3

jerryn70 commented 7 years ago

Well keep this issue open for 2 days. I will continue my investigation and report you.

jerryn70 commented 7 years ago

I have uninstalled and reinstalled Bitwarden still iam facing this issue. So I decided to record a video to show you. But whenever I record a video using screen recorder app , autofil is working. If I stop screen recording then autofil will not work.
So I will shoot a video using another phone an show you.

If you tested this apps with screen recorder ON then pls stop it and try again

jerryn70 commented 7 years ago

@kspearrin here is the video

https://www.dropbox.com/s/tq5ppm1fan7gg7z/WP_20171106_002.mp4?dl=0

https://www.dropbox.com/s/1vgoho9g97ul5cy/WP_20171106_003.mp4?dl=0

kspearrin commented 7 years ago

Very weird. Let me try with PIN enabled.

jerryn70 commented 7 years ago

Not even showing Bitwarden autofil notification for this app https://play.google.com/store/apps/details?id=in.amazon.mShop.android.shopping

kspearrin commented 7 years ago

I can reproduce the Amazon app issue. I'll have to look into that one more. I turned on PIN and it didn't make any difference for the others. Still worked correctly. Can you try some of the other autofill modes to see if they are also affected?

Silver0066 commented 6 years ago

It does not work for me. Autofill does not even pop up with any sign in app.
Is this a known bug, or maybe it doesn't work on a Samsung S7. Lastpass works just fine.

I would like to replace Lastpass with Bitwarden, but not if the autofill is not working on android. It works great on the PC's.

kspearrin commented 6 years ago

@Silver0066 please see https://help.bitwarden.com/article/auto-fill-android/

Silver0066 commented 6 years ago

Hi Kyle,

I already looked at that and everything is as suggested in the article. I am using Chrome on my android. Do you have any other suggestions?

From: Kyle Spearrin [mailto:notifications@github.com] Sent: Wednesday, December 13, 2017 9:31 AM To: bitwarden/mobile mobile@noreply.github.com Cc: Silver0066 billbort@gmail.com; Mention mention@noreply.github.com Subject: Re: [bitwarden/mobile] Auto fill not working properly on some apps (#159)

@Silver0066 https://github.com/silver0066 please see https://help.bitwarden.com/article/auto-fill-android/

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bitwarden/mobile/issues/159#issuecomment-351463709 , or mute the thread https://github.com/notifications/unsubscribe-auth/Ab2pg7lrVHNlY_wXwebegfOrhfWsnX6zks5tAAnGgaJpZM4QQyLA . https://github.com/notifications/beacon/Ab2pg4S-K1hVk3YuUrbZMKGGUQ4FNMKNks5tAAnGgaJpZM4QQyLA.gif

kspearrin commented 6 years ago

Try restarting the device?

Silver0066 commented 6 years ago

I just restarted the device. No change. The icon does not even show up when I click on password or username….just the keyboard.

From: Kyle Spearrin [mailto:notifications@github.com] Sent: Wednesday, December 13, 2017 10:08 AM To: bitwarden/mobile mobile@noreply.github.com Cc: Silver0066 billbort@gmail.com; Mention mention@noreply.github.com Subject: Re: [bitwarden/mobile] Auto fill not working properly on some apps (#159)

Try restarting the device?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bitwarden/mobile/issues/159#issuecomment-351474273 , or mute the thread https://github.com/notifications/unsubscribe-auth/Ab2pg936y3eVV0ymXA4EQ3O7hHfWW1xIks5tABKagaJpZM4QQyLA . https://github.com/notifications/beacon/Ab2pg0PJEZ1C532_d5Ytgk8pCChORXWjks5tABKagaJpZM4QQyLA.gif

kspearrin commented 6 years ago

Is this on a website in Chrome browser? What about when viewing a login form in a native app?

Silver0066 commented 6 years ago

It is on a login form in Chrome browser. I am not sure what you mean by a “native app”.

From: Kyle Spearrin [mailto:notifications@github.com] Sent: Wednesday, December 13, 2017 10:27 AM To: bitwarden/mobile mobile@noreply.github.com Cc: Silver0066 billbort@gmail.com; Mention mention@noreply.github.com Subject: Re: [bitwarden/mobile] Auto fill not working properly on some apps (#159)

Is this on a website in Chrome browser? What about when viewing a login form in a native app?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bitwarden/mobile/issues/159#issuecomment-351479187 , or mute the thread https://github.com/notifications/unsubscribe-auth/Ab2pg7F5_Rw6RvKXBQdYwnedXgAzIFnPks5tABbagaJpZM4QQyLA . https://github.com/notifications/beacon/Ab2pg-TcJ36Bc9OvOl5MRbTDymsCQOGDks5tABbagaJpZM4QQyLA.gif

kspearrin commented 6 years ago

I mean an app on your phone that has a login form that is not a webpage.

Silver0066 commented 6 years ago

OK, thanks. I tried it on a native app…Starbucks. Still no change and no icon popup.

From: Kyle Spearrin [mailto:notifications@github.com] Sent: Wednesday, December 13, 2017 10:32 AM To: bitwarden/mobile mobile@noreply.github.com Cc: Silver0066 billbort@gmail.com; Mention mention@noreply.github.com Subject: Re: [bitwarden/mobile] Auto fill not working properly on some apps (#159)

I mean an app on your phone that has a login form that is not a webpage.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bitwarden/mobile/issues/159#issuecomment-351480829 , or mute the thread https://github.com/notifications/unsubscribe-auth/Ab2pg4hWeRGmtlTw1Plf9yukbPO4LGB6ks5tABgugaJpZM4QQyLA . https://github.com/notifications/beacon/Ab2pg4sYj-AjapN2hfzct929JHPaamZ6ks5tABgugaJpZM4QQyLA.gif

Sn1cket commented 6 years ago

Hi, I am having a similar problem with some apps, but with the Android 8 Autofill Service.

Auto fill method : password field focused Android version 8.0.0 (Oneplus OxygenOS 5.0.1) Bitwarden version : 1.14.1 (1249)

Specific in these three apps I don't even get a popup to autofill with bitwarden:

Should the autofill service also work for mobile browsers? Because I tried three different browsers (Chrome, Firefox, Dolphin) and in none of them the autofill popup appeared.

kspearrin commented 6 years ago

@Sn1cket

Auto fill method : password field focused

This setting only works for the accessibility service. It does not apply to android 8 autofill.

Android 8 autofill still has limited support and doesn't work in web browsers (except firefox focus). Google is suppose to be improving it over time.

walrus543 commented 6 years ago

@kspearrin I no longer get the notification when selecting a password field with Firefox Focus/Klar. I don't know if it's related to an update of bitwarden or Focus/Klar.

kspearrin commented 6 years ago

@Primokorn We haven't pushed an update for a few weeks now so nothing changed here.

walrus543 commented 6 years ago

@kspearrin Then Mozilla has changed something which brokes bitwarden's detection. Could you have a look? Do you want me to send you a log?

kspearrin commented 6 years ago

Just tested accessibility service in focus and it worked fine on github login page?

walrus543 commented 6 years ago

Here is a comparison between Firefox Klar and my Chromium based browser (see the notification).

kspearrin commented 6 years ago

I think Klar is only supported in the latest beta. I am not sure if that made it to production yet since it was recently requested we add support for it vs focus (they have different package names).

kspearrin commented 6 years ago

Nevermind. I am able to reproduce this on Focus this morning using the "focus password field" option.

walrus543 commented 6 years ago

The problem is still there with Firefox Klar (org.mozilla.klar v4.0.2) A new app where auto-fill doesn't work: Via browser (mark.via.gp v3.3.2) Tested with bitwarden 1.15.2 - Scan when password field focused - Android Oreo 8.1.0

kspearrin commented 6 years ago

@Primokorn ref via, see: https://community.bitwarden.com/t/add-via-browser-support/561/2?u=kspearrin

jeroenev commented 6 years ago

any other android browsers that support android oreo autofill? :) Oreo autofill works fine for me in firefox Focus / klar, but not in regular firefox, or chrome, or any other browser so far

walrus543 commented 6 years ago

@jeroen7s Bromite.

jeroenev commented 6 years ago

@Primokorn i use bromite but i've not seen any popup from the new autofill API

jeroenev commented 6 years ago

also bromite needs to be added to the supported browser list for legacy accessibility autofill, since bitwarden doesn't seem to detect it is a browser, but treats it as a regular app

walrus543 commented 6 years ago

@jeroen7s My bad. I thought you were talking about the notification (legacy accessibility autofill). Actually I've never used any web browser with the Autofill API. Klar (v4.1) doesn't work at all on my end (legacy or new API).

walrus543 commented 6 years ago

@kspearrin • Bromite browser
When I press the notification to find my credentials for a given website, Bitwarden doesn't use the URI to suggest credentials. I have to search them manually. Bitwarden searches credentials for org.bromite.bromite (app package name)
I thought it was a limitation of Bitwarden... until I tried Brave...

• Brave browser
This browser has the same base as Bromite (Chromium) but Bitwarden suggests me credentials based on the URI.

What's the problem with Bromite? Is it something that should be improved on your side or on Bromite app?
Thanks.

kspearrin commented 6 years ago

@Primokorn I have to add support for each browser manually. How do I download Bromite? I see lots of apks on their releases page. Not sure which one I need https://github.com/bromite/bromite/releases

jeroenev commented 6 years ago

if you have a phone from the last 3 years, you'd best use ARM64 (64 bit) and ModernChrome without the Modern is for pre-lolipop android (before android 5.0) the one with Mono is for nougat and above (android 7+) x86 is for the rare devices that have an intel chip (mostly some older ASUS zenphones i think) so you probably need this one for lolipop/marshmallow https://github.com/bromite/bromite/releases/download/67.0.3396.72/arm64_ChromeModernPublic.apk or this one for nougat/oreo/popsicle: https://github.com/bromite/bromite/releases/download/67.0.3396.72/arm64_MonochromePublic.apk though the ChromeModern will also work on Nougat

jeroenev commented 6 years ago

on bromite.org it's more clear (kinda) there you have checkboxes for which architecture and android version you have above the download button You can also download it from the XDA-labs app store

walrus543 commented 6 years ago

@kspearrin To give additional information to @jeroen7s's answer.
AFAIR you have a Nexus 5X so download arm64_ChromeModernPublic.apk
More technical details here

EDIT: btw I thought Bromite was already supported.

kspearrin commented 6 years ago

Added https://github.com/bitwarden/mobile/commit/b5277e89d56f17e0e5759cb6870feda5abae15a7

kspearrin commented 6 years ago

I pushed the update to the beta channel on play store.

walrus543 commented 6 years ago

@kspearrin Thanks. It works flawlessly :+1:

csagan5 commented 6 years ago

How do I download Bromite? I see lots of apks on their releases page. Not sure which one I need https://github.com/bromite/bromite/releases

On the official website you should get the right combination highlighted in green; this is done via javascript by checking the browser's reported CPU type and Android version.

Unfortunately it was not possible to publish it on Play Store, the F-Droid build requires more work and XDA Labs app does not support multi-arch/sdk (sigh), so for a lack of better delivery platform I thought to leave the situation as is for now (à la OpenGapps), with the official website offering download links to the Github releases.

walrus543 commented 6 years ago

@kspearrin That's weird. Some Chromium based browsers don't have to be added manually. Legacy autofill service is working while you didn't include this browser: https://forum.xda-developers.com/android/apps-games/app-kiwi-browser-chromium-adblock-caf-t3797252

kspearrin commented 6 years ago

@Primokorn I added kiwi browser a couple of days ago

walrus543 commented 6 years ago

@kspearrin oh sorry, just found the commit

jyavenard commented 6 years ago

There's a few apps for which autofill doesn't work at all or doesn't work reliably.

Financial Times app doesn't work at all for me.

There's the Bourse Direct (French app) for which it works very unreliably, and I typically have to go into bitwarden, manually copy the password and come back into the app. The previous way of having bitwarden fill forms via the notification was working 100%. Now that this is no longer there, and have to wait for the popup to show, which typically doesn't.

csagan5 commented 4 years ago

I am still puzzled on why Bitwarden works correctly on Chrome but not on Chromium/Bromite (no Sync login needed). Has anyone done some research on this? The package names seem all covered by Bitwarden.

See also my comment here.

Edit: updated comment URL

eliykat commented 3 years ago

Thanks for reporting this issue. Autofill problems can affect different sites, apps, or devices, and we’re working on improving this feature. To help us track and analyze affected sites, please lodge a report using the Google Form mentioned in this issue: #1389. Please also direct any discussion or questions to that issue. This issue will now be closed.