bitwarden / android

Bitwarden mobile app for Android.
https://bitwarden.com
GNU General Public License v3.0
5.86k stars 763 forks source link

Windows accessibility bug #3307

Closed RafaelFernandesBR closed 2 weeks ago

RafaelFernandesBR commented 2 weeks ago

Steps To Reproduce

  1. When searching for an item in the search, the results are displayed.
  2. Clicking on any of the results opens the clicked item screen on top of the results screen.
  3. Clicking to edit the item opens the edit screen on top of the item screen and, at the same time, the results screen.
  4. Clicking to generate a new password opens the generator screen on top of all the previously mentioned screens.

Expected Result

  1. when clicking on a result, a new window separate from the search results window should open.
  2. when clicking edit on the item, a new window should open separate from the previous ones.
  3. and so on, the windows should not overlap each other.

Actual Result

Clicking on the search result opens the item detail above the results. When clicking on edit the item, it opens the editing window over the previous two windows, when generating a new password, it opens the generator screen over the previous 3.

Screenshots or Videos

No response

Additional Context

Hello. I wanted to report 2 bugs that I found in the latest versions of Bitwarden, it's been about 2 months now.

When we search for passwords in the search bar and the results are displayed, clicking on a result to view the credential data, instead of opening that credential in a new window, it opens on top of the search results. This disrupts those of us who use screen readers like TalkBack because as the windows start to overlap the results, the screen reader gets completely confused about what to read. Ideally, it should work as it did before, when clicking on a result opened a new window separate from the search result, providing a better view of the item we want to view or edit, just as it happens when we click on a credential without searching.

When we want to edit an item after searching for it, it becomes practically impossible to edit it because there is an overwhelming mix of screens open on top of each other at the same time. For example:

  1. When searching for an item in the search, the results are displayed.
  2. Clicking on any of the results opens the clicked item screen on top of the results screen.
  3. Clicking to edit the item opens the edit screen on top of the item screen and, at the same time, the results screen.
  4. Clicking to generate a new password opens the generator screen on top of all the previously mentioned screens.

This makes it practically impossible to navigate the screen using any screen reader, whether it’s TalkBack or Jieshu, because when sliding your finger on the screen, it reads all the items it is viewing, that is, the search result screen with the items, the item details screen, the item edit screen, and the password generator screen. There are a lot of information on the screen at the same time!

Operating System

Android

Operating System Version

Android 13

Device

Redmi note 10S

Build Version

© Bitwarden Inc. 2015-2024 Version: 2024.5.1 (10574)

Beta

NovaSilentium commented 2 weeks ago

Hi there,

I am unable to reproduce this issue, it has been escalated for further investigation. If you have more information that can help us, please add it below.

Further that, its recommended to have bugs reported separately for tracking purposes. Please can you separate it and we will further investigate.

Thanks!

RafaelFernandesBR commented 2 weeks ago

Hello, Do a password search in the search bar, and click on a result. Navigate the screen using haptic scanning by swiping the screen from top to bottom. You will notice that the screen reader will read the results of the list and part of the information from the item opened Same time.

Em qui., 20 de jun. de 2024 05:33, NovaSilentium @.***> escreveu:

Hi there,

I am unable to reproduce this issue, it has been escalated for further investigation. If you have more information that can help us, please add it below.

Further that, its recommended to have bugs reported separately for tracking purposes.

Thanks!

— Reply to this email directly, view it on GitHub https://github.com/bitwarden/mobile/issues/3307#issuecomment-2180122594, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMKTFX655OKEMBX6KETIY7DZIKHVFAVCNFSM6AAAAABJSYURC2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBQGEZDENJZGQ . You are receiving this because you authored the thread.Message ID: @.***>

vvolkgang commented 2 weeks ago

Issue migrated to https://github.com/bitwarden/mobile/issues/3307