Closed SaintPatrck closed 3 months ago
Checkmarx One – Scan Summary & Details – 1e87d009-85f9-4b3a-b545-b46fb953d2f1
Severity | Issue | Source File / Package |
---|---|---|
Privacy_Violation | /app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt: 660 | |
Privacy_Violation | /app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt: 660 | |
Privacy_Violation | /app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt: 660 | |
Privacy_Violation | /app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt: 660 | |
Privacy_Violation | /app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt: 660 | |
Privacy_Violation | /app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt: 346 |
88.37%
File | Coverage |
---|---|
CallingAppInfoExtensions.kt |
100.00% |
CipherViewExtensions.kt |
83.36% |
Fido2CredentialManagerImpl.kt |
96.72% |
VaultAddEditScreen.kt |
85.61% |
VaultAddEditViewModel.kt |
92.45% |
VaultRepositoryImpl.kt |
87.98% |
VaultSdkSourceImpl.kt |
85.55% |
CallingAppInfoExtensionsTest.kt CipherJsonRequestUtil.kt CipherViewExtensionsTest.kt CipherViewUtil.kt Fido2AttestationResponse.kt FindFido2CredentialsResult.kt OrganizationEventManagerTest.kt PubliKeyCredentialAuthenticatorAttestationResponseExtensions.kt SaveCredentialResult.kt VaultAddEditScreenTest.kt VaultAddEditViewModelTest.kt VaultRepository.kt VaultSdkSource.kt VaultSdkSourceTest.kt
Codebase cunningly covered by count Shroud 🧛
Generated by :no_entry_sign: Danger
Attention: Patch coverage is 68.35443%
with 50 lines
in your changes missing coverage. Please review.
Project coverage is 85.57%. Comparing base (
44e2596
) to head (cc9de35
). Report is 7 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-8137
📔 Objective
Allow users to register a new FIDO 2 credential (passkey) to a new cipher.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or ⚠️ (:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes