bitwarden / android

Bitwarden mobile app for Android.
https://bitwarden.com
GNU General Public License v3.0
6.33k stars 797 forks source link

[PM-8137] Allow registering a passkey to a new cipher #3329

Closed SaintPatrck closed 3 months ago

SaintPatrck commented 3 months ago

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-8137

📔 Objective

Allow users to register a new FIDO 2 credential (passkey) to a new cipher.

📸 Screenshots

imageimageimage

imageimage

⏰ Reminders before review

🦮 Reviewer guidelines

github-actions[bot] commented 3 months ago

Logo Checkmarx One – Scan Summary & Details1e87d009-85f9-4b3a-b545-b46fb953d2f1

Fixed Issues

Severity Issue Source File / Package
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt: 660
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt: 660
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt: 660
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt: 660
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt: 660
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt: 346
github-actions[bot] commented 3 months ago

🧛 App Code Coverage: 88.37%

Coverage of Modified Files:

File Coverage
CallingAppInfoExtensions.kt 100.00%
CipherViewExtensions.kt 83.36%
Fido2CredentialManagerImpl.kt 96.72%
VaultAddEditScreen.kt 85.61%
VaultAddEditViewModel.kt 92.45%
VaultRepositoryImpl.kt 87.98%
VaultSdkSourceImpl.kt 85.55%

Modified Files Not Found In Coverage Report:

CallingAppInfoExtensionsTest.kt CipherJsonRequestUtil.kt CipherViewExtensionsTest.kt CipherViewUtil.kt Fido2AttestationResponse.kt FindFido2CredentialsResult.kt OrganizationEventManagerTest.kt PubliKeyCredentialAuthenticatorAttestationResponseExtensions.kt SaveCredentialResult.kt VaultAddEditScreenTest.kt VaultAddEditViewModelTest.kt VaultRepository.kt VaultSdkSource.kt VaultSdkSourceTest.kt

Codebase cunningly covered by count Shroud 🧛

Generated by :no_entry_sign: Danger

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 68.35443% with 50 lines in your changes missing coverage. Please review.

Project coverage is 85.57%. Comparing base (44e2596) to head (cc9de35). Report is 7 commits behind head on main.

Files Patch % Lines
...t/feature/itemlisting/VaultItemListingViewModel.kt 0.00% 21 Missing and 2 partials :warning:
...en/data/vault/datasource/sdk/VaultSdkSourceImpl.kt 80.39% 10 Missing :warning:
.../ui/vault/feature/addedit/VaultAddEditViewModel.kt 80.64% 5 Missing and 1 partial :warning:
...tofill/fido2/manager/Fido2CredentialManagerImpl.kt 85.71% 2 Missing and 3 partials :warning:
...arden/data/vault/repository/VaultRepositoryImpl.kt 16.66% 5 Missing :warning:
...den/ui/vault/feature/addedit/VaultAddEditScreen.kt 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3329 +/- ## ========================================== - Coverage 85.66% 85.57% -0.09% ========================================== Files 356 356 Lines 28917 29063 +146 Branches 5010 5032 +22 ========================================== + Hits 24772 24872 +100 - Misses 2123 2163 +40 - Partials 2022 2028 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.