bitwarden / android

Bitwarden mobile app for Android.
https://bitwarden.com
GNU General Public License v3.0
5.85k stars 760 forks source link

Add organization event tracking #3346

Closed david-livefront closed 1 week ago

david-livefront commented 1 week ago

🎟ī¸ Tracking

BIT-2419

📔 Objective

This PR adds most of the organization events to the app, a second PR will be coming shortly to get the last of them.

⏰ Reminders before review

đŸĻŽ Reviewer guidelines

github-actions[bot] commented 1 week ago

Logo Checkmarx One – Scan Summary & Details – 652f5830-d108-493a-becf-374da39c16ce

Fixed Issues

Severity Issue Source File / Package
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModel.kt: 366
github-actions[bot] commented 1 week ago

🧛 App Code Coverage: 88.59%

Coverage of Modified Files:

File Coverage
AutofillCompletionManagerImpl.kt 94.41%
CipherViewExtensions.kt 84.81%
FillResponseBuilderImpl.kt 100.00%
SearchViewModel.kt 91.24%
VaultAddEditViewModel.kt 92.35%
VaultItemListingViewModel.kt 94.85%
VaultItemViewModel.kt 95.05%
VaultViewModel.kt 89.37%

Modified Files Not Found In Coverage Report:

AutofillCompletionManagerTest.kt AutofillModule.kt CipherViewExtensionsTest.kt FillResponseBuilderTest.kt ListingItemOverflowAction.kt SearchScreenTest.kt SearchUtil.kt SearchViewModelTest.kt VaultAddEditViewModelTest.kt VaultItemListingDataUtil.kt VaultItemListingViewModelTest.kt VaultItemViewModelTest.kt VaultViewModelTest.kt

Codebase cunningly covered by count Shroud 🧛

Generated by :no_entry_sign: Danger

david-livefront commented 1 week ago

Thanks @brian-livefront & @SaintPatrck