bitwarden / android

Bitwarden mobile app for Android.
https://bitwarden.com
GNU General Public License v3.0
5.85k stars 760 forks source link

Add password reprompt for card number and code #3350

Closed david-livefront closed 1 week ago

david-livefront commented 1 week ago

🎟ī¸ Tracking

PM-7607

📔 Objective

This PR adds the master password re-prompt for the card cipher code and number.

📸 Screenshots

Before After

⏰ Reminders before review

đŸĻŽ Reviewer guidelines

github-actions[bot] commented 1 week ago

Logo Checkmarx One – Scan Summary & Details – af7a914f-18e1-4aa0-a59d-51883044dcb9

Fixed Issues

Severity Issue Source File / Package
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt: 581
github-actions[bot] commented 1 week ago

🧛 App Code Coverage: 88.58%

Coverage of Modified Files:

File Coverage
CipherViewExtensions.kt 83.23%
VaultCardItemTypeHandlers.kt 100.00%
VaultItemCardContent.kt 92.95%
VaultItemViewModel.kt 94.86%

Modified Files Not Found In Coverage Report:

VaultItemScreenTest.kt VaultItemViewModelTest.kt

Codebase cunningly covered by count Shroud 🧛

Generated by :no_entry_sign: Danger

david-livefront commented 1 week ago

Thanks @brian-livefront