Add edit cipher org events

bitwarden / android

Bitwarden mobile app for Android.

https://bitwarden.com

GNU General Public License v3.0

5.85k stars 760 forks source link

Add edit cipher org events #3352

Closed david-livefront closed 1 week ago

david-livefront commented 1 week ago

🎟️ Tracking

N/A

📔 Objective

This PR updates the VaultAddEditScreen to send actions into the ViewModel whenever the visibility of password, security code, number, or hidden field. This change allows us to log events for these updates.

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

github-actions[bot] commented 1 week ago

Checkmarx One – Scan Summary & Details – ad4f81b6-1fab-4c99-9652-f7313c38f71c

No New Or Fixed Issues Found

github-actions[bot] commented 1 week ago

	3 Warnings
:warning:	Uh oh! VaultAddEditCardItems.kt is under 80% coverage!
:warning:	Uh oh! VaultAddEditCustomField.kt is under 80% coverage!
:warning:	Uh oh! VaultAddEditIdentityItems.kt is under 80% coverage!

🧛 App Code Coverage: `88.61%`

Coverage of Modified Files:

File	Coverage
`VaultAddEditCardItems.kt`	`65.74%`
`VaultAddEditCardTypeHandlers.kt`	`100.00%`
`VaultAddEditCommonHandlers.kt`	`100.00%`
`VaultAddEditCustomField.kt`	`62.63%`
`VaultAddEditIdentityItems.kt`	`73.70%`
`VaultAddEditLoginItems.kt`	`86.88%`
`VaultAddEditLoginTypeHandlers.kt`	`100.00%`
`VaultAddEditSecureNotesItems.kt`	`90.09%`
`VaultAddEditViewModel.kt`	`92.55%`

Modified Files Not Found In Coverage Report:

VaultAddEditScreenTest.kt VaultAddEditViewModelTest.kt

Codebase cunningly covered by count Shroud 🧛

Generated by :no_entry_sign: Danger