bitwarden / android

Bitwarden mobile app for Android.
https://bitwarden.com
GNU General Public License v3.0
5.85k stars 760 forks source link

[BIT-2140] Add strings for typeform and export vault #3369

Closed SaintPatrck closed 1 week ago

SaintPatrck commented 1 week ago

🎟ī¸ Tracking

https://livefront.atlassian.net/browse/BIT-2140

📔 Objective

Move newly added strings related to feedback typeform and vault export to the primary strings resource file so they are tracked by Crowdin.

"MissingTranslation" lint check is disabled to allow source strings to be added without initial translations.

⏰ Reminders before review

đŸĻŽ Reviewer guidelines

github-actions[bot] commented 1 week ago

Logo Checkmarx One – Scan Summary & Details – b6486a8d-60fc-4830-8572-9dced6635082

No New Or Fixed Issues Found

david-livefront commented 1 week ago

I think we need to add this to the gradle file.

    lint {
        disable += "MissingTranslation"
    }
codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.68%. Comparing base (1e1d415) to head (2b77cd4). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3369 +/- ## ======================================= Coverage 85.68% 85.68% ======================================= Files 356 356 Lines 28903 28903 Branches 4998 4998 ======================================= Hits 24765 24765 Misses 2119 2119 Partials 2019 2019 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.