bitwarden / android

Bitwarden mobile app for Android.
https://bitwarden.com
GNU General Public License v3.0
5.85k stars 760 forks source link

Fix a screen capture bug that clears the setting when the app language changes #3372

Closed david-livefront closed 1 week ago

david-livefront commented 1 week ago

๐ŸŽŸ๏ธ Tracking

N/A

๐Ÿ“” Objective

This PR fixes a bug that clears the screen capture state on the activity whenever language changes (whenever it recomposes).

โฐ Reminders before review

๐Ÿฆฎ Reviewer guidelines

github-actions[bot] commented 1 week ago

Logo Checkmarx One โ€“ Scan Summary & Details โ€“ 1771273d-2aad-4d5a-8c9f-9484ad959ee6

No New Or Fixed Issues Found

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.66%. Comparing base (1bc348f) to head (92882fc).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3372 +/- ## ======================================= Coverage 85.65% 85.66% ======================================= Files 356 356 Lines 28911 28916 +5 Branches 5009 5010 +1 ======================================= + Hits 24765 24771 +6 Misses 2123 2123 + Partials 2023 2022 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

david-livefront commented 1 week ago

Thanks @SaintPatrck