bitwarden / android

Bitwarden mobile app for Android.
https://bitwarden.com
GNU General Public License v3.0
5.85k stars 760 forks source link

Fix bug where JWT token clearing premium status #3373

Closed david-livefront closed 1 week ago

david-livefront commented 1 week ago

šŸŽŸļø Tracking

N/A

šŸ“” Objective

This PR addresses an issue where the JWT premium status was returning false even when a user has premium. So we no longer use that value to update the premium status. The sync response is stilled used to update the premium state.

ā° Reminders before review

šŸ¦® Reviewer guidelines

github-actions[bot] commented 1 week ago

Logo Checkmarx One ā€“ Scan Summary & Details ā€“ 0a49d9bd-8079-4219-a3fc-562a7d4d235b

No New Or Fixed Issues Found

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.66%. Comparing base (1bc348f) to head (c6c3d39). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3373 +/- ## ======================================= Coverage 85.65% 85.66% ======================================= Files 356 356 Lines 28911 28910 -1 Branches 5009 5009 ======================================= Hits 24765 24765 Misses 2123 2123 + Partials 2023 2022 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

david-livefront commented 1 week ago

Thanks @brian-livefront