bitwarden / android

Bitwarden mobile app for Android.
https://bitwarden.com
GNU General Public License v3.0
5.85k stars 760 forks source link

[PM-8137] Perform user verification during FIDO 2 credential registration #3375

Open SaintPatrck opened 1 week ago

SaintPatrck commented 1 week ago

šŸŽŸļø Tracking

PM-8137

šŸ“” Objective

Perform user verification during a FIDO 2 credential registration request.

When saving a new cipher for FIDO 2 credential registration we evaluate the request to determine if user verification should be performed. If user verification cannot be performed the user is notified, and upon acknowledgment the registration process is completed.

WIP

šŸ“ø Screenshots

Coming soon!

ā° Reminders before review

šŸ¦® Reviewer guidelines

github-actions[bot] commented 1 week ago

Logo Checkmarx One ā€“ Scan Summary & Details ā€“ d5a500fc-4103-4e20-ba41-9626df806ba0

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt: 581 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt: 347
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt: 661
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt: 661
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt: 661
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt: 661
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt: 661