bitwarden / android

Bitwarden mobile app for Android.
https://bitwarden.com
GNU General Public License v3.0
5.85k stars 760 forks source link

PM-9081: Should cancel the job not the scope when managing autofill requests #3389

Closed david-livefront closed 3 days ago

david-livefront commented 3 days ago

๐ŸŽŸ๏ธ Tracking

PM-9081

๐Ÿ“” Objective

This PR addresses an issue where autofill would not display any options, this occurred because the scope used to process autofill requests would be cancelled and then no no requests could ever be processed.

โฐ Reminders before review

๐Ÿฆฎ Reviewer guidelines

github-actions[bot] commented 3 days ago

Logo Checkmarx One โ€“ Scan Summary & Details โ€“ f8e0e240-1c92-4853-9434-897beffe54d0

No New Or Fixed Issues Found

codecov[bot] commented 3 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.66%. Comparing base (d7032b8) to head (558440e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3389 +/- ## ======================================= Coverage 85.66% 85.66% ======================================= Files 356 356 Lines 28915 28917 +2 Branches 5010 5010 ======================================= + Hits 24770 24772 +2 Misses 2123 2123 Partials 2022 2022 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

david-livefront commented 3 days ago

Thanks @brian-livefront