bitwarden / android

Bitwarden mobile app for Android.
https://bitwarden.com
GNU General Public License v3.0
5.85k stars 760 forks source link

BIT-2438: Update push notification processing logic to be more lenient #3393

Closed david-livefront closed 2 days ago

david-livefront commented 2 days ago

๐ŸŽŸ๏ธ Tracking

BIT-2438

๐Ÿ“” Objective

This PR updates the logic for processing notifications to parse the payloads assuming anything can be null.

โฐ Reminders before review

๐Ÿฆฎ Reviewer guidelines

github-actions[bot] commented 2 days ago

Logo Checkmarx One โ€“ Scan Summary & Details โ€“ b42207c4-4252-44c2-bbc4-fed21c27c60d

No New Or Fixed Issues Found

codecov[bot] commented 2 days ago

Codecov Report

Attention: Patch coverage is 57.89474% with 32 lines in your changes missing coverage. Please review.

Project coverage is 85.58%. Comparing base (f5039d7) to head (29aba7c).

Files Patch % Lines
...bitwarden/data/platform/manager/PushManagerImpl.kt 57.89% 0 Missing and 32 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3393 +/- ## ========================================== - Coverage 85.65% 85.58% -0.08% ========================================== Files 356 356 Lines 28922 28937 +15 Branches 5015 5039 +24 ========================================== - Hits 24774 24766 -8 Misses 2123 2123 - Partials 2025 2048 +23 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

david-livefront commented 2 days ago

Thanks @brian-livefront