bitwarden / android

Bitwarden mobile app for Android.
https://bitwarden.com
GNU General Public License v3.0
5.85k stars 760 forks source link

BIT-2442: check type before extracting autofill text #3394

Closed david-livefront closed 2 days ago

david-livefront commented 2 days ago

๐ŸŽŸ๏ธ Tracking

BIT-2442

๐Ÿ“” Objective

This PR adds a check to avoid an exception when attempting to parse autofill data as text.

โฐ Reminders before review

๐Ÿฆฎ Reviewer guidelines

github-actions[bot] commented 2 days ago

Logo Checkmarx One โ€“ Scan Summary & Details โ€“ 7735995e-0228-4dbd-960d-c9187f5aa855

No New Or Fixed Issues Found

codecov[bot] commented 2 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.65%. Comparing base (f5039d7) to head (47cec19).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3394 +/- ## ======================================= Coverage 85.65% 85.65% ======================================= Files 356 356 Lines 28922 28924 +2 Branches 5015 5016 +1 ======================================= + Hits 24774 24776 +2 Misses 2123 2123 Partials 2025 2025 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

david-livefront commented 2 days ago

Thanks @brian-livefront