bitwarden / android

Bitwarden mobile app for Android.
https://bitwarden.com
GNU General Public License v3.0
5.85k stars 760 forks source link

BIT-2443: Fix crash caused by extra blank spaces in name #3395

Closed david-livefront closed 2 days ago

david-livefront commented 2 days ago

🎟ī¸ Tracking

BIT-2443

📔 Objective

This PR fixes a crash when parsing initials that have extra blank spaces in them.

Stacktrace:

   Fatal Exception: java.util.NoSuchElementException: Char sequence is empty.
       at kotlin.text.StringsKt___StringsKt.first(_Strings.kt:76)
       at com.x8bit.bitwarden.ui.vault.feature.vault.util.AccountSummaryExtensionsKt._get_initials_$lambda$0(AccountSummaryExtensions.kt:25)
       at com.x8bit.bitwarden.ui.vault.feature.vault.util.AccountSummaryExtensionsKt.$r8$lambda$75K7JSwE63qgrtaNuTKqE1qCJyM()
       at com.x8bit.bitwarden.ui.vault.feature.vault.util.AccountSummaryExtensionsKt$$ExternalSyntheticLambda0.invoke(D8$$SyntheticClass)
       at kotlin.text.StringsKt__AppendableKt.appendElement(Appendable.kt:84)
       ...

⏰ Reminders before review

đŸĻŽ Reviewer guidelines

github-actions[bot] commented 2 days ago

Logo Checkmarx One – Scan Summary & Details – bafd86e5-11bc-4010-969f-665e2d8db342

No New Or Fixed Issues Found

codecov[bot] commented 2 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.58%. Comparing base (bb6a7af) to head (933f9ec).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3395 +/- ## ======================================= Coverage 85.58% 85.58% ======================================= Files 356 356 Lines 28939 28939 Branches 5040 5040 ======================================= Hits 24768 24768 Misses 2123 2123 Partials 2048 2048 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

david-livefront commented 2 days ago

Thanks @brian-livefront