bitwarden / android

Bitwarden mobile app for Android.
https://bitwarden.com
GNU General Public License v3.0
6.21k stars 788 forks source link

Keyboard submit button do not work on master password or PIN field #3680

Closed user-naa closed 2 weeks ago

user-naa commented 1 month ago

Bitwarden Beta

Steps To Reproduce

  1. Lock vault with password or PIN
  2. Click unlock input field and enter password/PIN
  3. Press submit button on your keyboard

Expected Result

Nothing happens

Actual Result

Password should be verified and vault unlocked of password correct

Build Version

2024.7.3 (18938)

Issue Tracking Info

bitwarden-bot commented 1 month ago

Thank you for your report! We've added this to our internal board for review. ID: PM-10658

qwexter commented 1 month ago

Yes, it's work as is and I try to fix it in this screen with some minor improvements. We got an answer from dev team, this behavior must be synced with UX\UI team (It's my guess, I don't know what's MAUI mean)

qwexter commented 1 month ago

Or I leave here)

Description: The current app does not work properly with Keyboard Actions, which can make it difficult to use certain features, such as:

PIN code input screen: If you press the "Done" button on your keyboard, the keyboard will close, and you'll need to press the CTA (Call-to-Action) button again. Master password setup: Similarly, when using Keyboard Actions on this screen, the app does not recognize the "Done" button press. Proposal: I suggest adding support for Keyboard Actions in the following scenarios:

Single CTA button: When there's only one possible action on a screen (e.g., a single button to confirm), allow users to trigger it using a keyboard action. Multiple input fields: If there are multiple input fields on a screen, use Keyboard Actions to focus on the next field after completing each one, and finally perform the CTA action.

Why is this important? By implementing these improvements, we can enhance the overall user experience of our app, making it more intuitive and efficient for users to interact with it.

As is Can be
keyboard_actions_as_is keyboard_actions_can_be
qwexter commented 1 month ago

@SaintPatrck maybe this issue and my ideas help you with MAUI and other things.

micahblut commented 2 weeks ago

Fixed with #3691 Thank you @qwexter