bitwarden / android

Bitwarden mobile app for Android.
https://bitwarden.com
GNU General Public License v3.0
6.33k stars 797 forks source link

BITAU-164 add no-op version of BridgeService #3884

Closed ahaisting-livefront closed 3 weeks ago

ahaisting-livefront commented 3 weeks ago

🎟ī¸ Tracking

https://livefront.atlassian.net/browse/BITAU-164

📔 Objective

The goal of this PR is to set up a no-op BridgeService that is returned whenever the feature flag for authenticator sync is turned of.

📸 Screenshots

N/A

⏰ Reminders before review

đŸĻŽ Reviewer guidelines

github-actions[bot] commented 3 weeks ago

Logo Checkmarx One – Scan Summary & Details – 105c829e-fc6a-4434-b182-48236c21cfe0

No New Or Fixed Issues Found

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 42.85714% with 8 lines in your changes missing coverage. Please review.

Project coverage is 88.61%. Comparing base (b7544ef) to head (4b91246). Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...a/platform/processor/BridgeServiceProcessorImpl.kt 60.00% 4 Missing :warning:
...t/bitwarden/data/platform/service/BridgeService.kt 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3884 +/- ## ========================================== - Coverage 88.62% 88.61% -0.02% ========================================== Files 409 411 +2 Lines 33744 33758 +14 Branches 4986 4987 +1 ========================================== + Hits 29907 29913 +6 - Misses 2083 2091 +8 Partials 1754 1754 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ahaisting-livefront commented 3 weeks ago

Thanks, @david-livefront and @SaintPatrck !