bitwarden / android

Bitwarden mobile app for Android.
https://bitwarden.com
GNU General Public License v3.0
6.33k stars 797 forks source link

PM-10630 setup autofill UI and interactions set up #3891

Closed dseverns-livefront closed 3 weeks ago

dseverns-livefront commented 3 weeks ago

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-10630

๐Ÿ“” Objective

๐Ÿ“ธ Screenshots

image

โฐ Reminders before review

๐Ÿฆฎ Reviewer guidelines

dseverns-livefront commented 3 weeks ago

NOTES 90% of work for PM-10631 is in here (turn on later dialog). Will have separate PR once this is merged and #3878 merged.

github-actions[bot] commented 3 weeks ago

Logo Checkmarx One โ€“ Scan Summary & Details โ€“ 0fe5e4a8-f8e5-4e67-80a8-9dbd3dd6ab8d

No New Or Fixed Issues Found

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 97.07602% with 5 lines in your changes missing coverage. Please review.

Project coverage is 88.67%. Comparing base (b7544ef) to head (a37508d). Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...i/auth/feature/accountsetup/SetupAutofillScreen.kt 96.00% 2 Missing and 2 partials :warning:
...ture/accountsetup/handlers/SetupAutoFillHandler.kt 95.23% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3891 +/- ## ========================================== + Coverage 88.62% 88.67% +0.04% ========================================== Files 409 412 +3 Lines 33744 33915 +171 Branches 4986 5001 +15 ========================================== + Hits 29907 30073 +166 - Misses 2083 2085 +2 - Partials 1754 1757 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.