bitwarden / android

Bitwarden mobile app for Android.
https://bitwarden.com
GNU General Public License v3.0
6.33k stars 797 forks source link

BITAU-103 Implement symmetric key creation and storage #3905

Closed ahaisting-livefront closed 2 weeks ago

ahaisting-livefront commented 3 weeks ago

๐ŸŽŸ๏ธ Tracking

https://livefront.atlassian.net/browse/BITAU-103

๐Ÿ“” Objective

The goal of this PR is to setup the one time symmetric key generation. This will be required for implementing BridgeService, which is up next!

๐Ÿ“ธ Screenshots

โฐ Reminders before review

๐Ÿฆฎ Reviewer guidelines

github-actions[bot] commented 3 weeks ago

Logo Checkmarx One โ€“ Scan Summary & Details โ€“ 50bd214a-fa0f-4f51-96e8-3c8c3028110f

No New Or Fixed Issues Found

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 88.70%. Comparing base (2721f72) to head (00758d5). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...en/data/auth/datasource/disk/AuthDiskSourceImpl.kt 0.00% 4 Missing :warning:
...data/platform/repository/SettingsRepositoryImpl.kt 75.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3905 +/- ## ========================================== - Coverage 88.71% 88.70% -0.02% ========================================== Files 423 423 Lines 34343 34351 +8 Branches 5073 5077 +4 ========================================== + Hits 30468 30471 +3 - Misses 2101 2105 +4 - Partials 1774 1775 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ahaisting-livefront commented 2 weeks ago

Thanks, @brian-livefront !