bitwarden / android

Bitwarden mobile app for Android.
https://bitwarden.com
GNU General Public License v3.0
6.33k stars 797 forks source link

[PM-12595] add notification badge to settings item in settings tab screen #3976

Closed dseverns-livefront closed 6 days ago

dseverns-livefront commented 1 week ago

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-12595

๐Ÿ“” Objective

๐Ÿ“ธ Screenshots

image

โฐ Reminders before review

๐Ÿฆฎ Reviewer guidelines

github-actions[bot] commented 1 week ago

Logo Checkmarx One โ€“ Scan Summary & Details โ€“ 7fc617a8-b4a0-4d8c-bb22-59c5a6862a29

No New Or Fixed Issues Found

codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 97.91667% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.86%. Comparing base (f349a72) to head (5fae5a6). Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...den/ui/platform/feature/settings/SettingsScreen.kt 94.73% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3976 +/- ## ======================================= Coverage 88.85% 88.86% ======================================= Files 425 425 Lines 35074 35118 +44 Branches 5137 5140 +3 ======================================= + Hits 31164 31206 +42 - Misses 2116 2119 +3 + Partials 1794 1793 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.