bitwarden / android

Bitwarden mobile app for Android.
https://bitwarden.com
GNU General Public License v3.0
6.33k stars 797 forks source link

Add BitwardenOutlinedErrorButton and rename BitwardenErrorButton #3984

Closed david-livefront closed 6 days ago

david-livefront commented 6 days ago

🎟ī¸ Tracking

N/A

📔 Objective

This PR renames the BitwardenErrorButton to BitwardenFilledErrorButton to be more inline with the naming conventions and adds a new BitwardenOutlinedErrorButton which will be used in the future.

No functional or visual changes were made in this PR.

⏰ Reminders before review

đŸĻŽ Reviewer guidelines

github-actions[bot] commented 6 days ago

Logo Checkmarx One – Scan Summary & Details – 3369b18a-5fc3-4932-bb60-a5c58059e993

No New Or Fixed Issues Found

codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.86%. Comparing base (853f25b) to head (8683b61). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3984 +/- ## ======================================= Coverage 88.86% 88.86% ======================================= Files 425 425 Lines 35051 35051 Branches 5136 5136 ======================================= Hits 31147 31147 Misses 2111 2111 Partials 1793 1793 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

david-livefront commented 6 days ago

Thanks @brian-livefront