bitwarden / android

Bitwarden mobile app for Android.
https://bitwarden.com
GNU General Public License v3.0
6.33k stars 797 forks source link

[PM-13073] Handle Fido2 credential errors on vault unlock screen #4010

Closed SaintPatrck closed 10 hours ago

SaintPatrck commented 2 days ago

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13073

📔 Objective

This commit adds logic to handle Fido2 credential errors on the vault unlock screen.

⏰ Reminders before review

🦮 Reviewer guidelines

github-actions[bot] commented 2 days ago

Logo Checkmarx One – Scan Summary & Details72950493-362f-4897-9dbf-80cdbbc22a68

No New Or Fixed Issues Found

codecov[bot] commented 2 days ago

Codecov Report

Attention: Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.88%. Comparing base (0c83a10) to head (dc963c8). Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...n/ui/auth/feature/vaultunlock/VaultUnlockScreen.kt 75.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4010 +/- ## ======================================= Coverage 88.88% 88.88% ======================================= Files 425 425 Lines 35098 35121 +23 Branches 5143 5147 +4 ======================================= + Hits 31196 31218 +22 - Misses 2108 2109 +1 Partials 1794 1794 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.