Closed david-livefront closed 2 weeks ago
Checkmarx One ā Scan Summary & Details ā 7d7bfc84-b099-4771-bc41-dd87201a648e
Attention: Patch coverage is 98.05447%
with 5 lines
in your changes missing coverage. Please review.
Project coverage is 89.01%. Comparing base (
771e719
) to head (82bd1be
). Report is 3 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks @SaintPatrck & @dseverns-livefront
šļø Tracking
PM-14805
š Objective
This PR adds a new class called
NetworkResult
to the app and uses it in place ofResult
for all network requests.This is done to avoid a
ClassCastException
that can occur where theResult
in unnecessarily boxed creating aResult<Result<T>>
. This should not happen with the newNetworkResult
.We will continue to use the regular
Result
everywhere else in the app.ā° Reminders before review
š¦® Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ā¹ļø (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or š (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or ā ļø (:warning:
) for more significant problems or concerns needing attention:seedling:
) or ā»ļø (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes