PM-14429 Set the min and max range of the slider to match the restrictions not update the min with the computed min.

dseverns-livefront commented 1 week ago

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14429

📔 Objective

When decreasing the min numbers or special characters the value continues to change because the length of the pw does not change and the minimum range is changing.

📸 Screenshots

Before: See story After:

https://github.com/user-attachments/assets/56807212-d0f7-4ae4-a9dc-a5d8afc1cb1d

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

github-actions[bot] commented 1 week ago

Checkmarx One – Scan Summary & Details – 666676d8-0937-4e34-bf02-3cf257a2f0ee

No New Or Fixed Issues Found

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.96%. Comparing base (40f33df) to head (177e53b). Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
...rden/ui/tools/feature/generator/GeneratorScreen.kt	75.00%	0 Missing and 1 partial :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #4305 +/- ## ========================================== - Coverage 88.97% 88.96% -0.01% ========================================== Files 453 453 Lines 38979 38981 +2 Branches 5493 5494 +1 ========================================== + Hits 34680 34681 +1 Misses 2373 2373 - Partials 1926 1927 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bitwarden / android