Closed david-livefront closed 1 week ago
Checkmarx One â Scan Summary & Details â ac7d8f98-cd42-467a-9d6e-f39e5b012965
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 89.01%. Comparing base (
1b0bc13
) to head (fd6164e
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks @dseverns-livefront
đī¸ Tracking
PM-12259
đ Objective
This PR update the
validatePin
function in theAuthRepository
to use the purpose-made SDK function to validate the pin. This fixes some bugs that can occur from calling theinitializeCrypto
function in unexpected places, which is how the previous logic worked.â° Reminders before review
đĻŽ Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or âšī¸ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or đ (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or â ī¸ (:warning:
) for more significant problems or concerns needing attention:seedling:
) or âģī¸ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes