bitwarden / android

Bitwarden mobile app for Android.
https://bitwarden.com
GNU General Public License v3.0
6.56k stars 821 forks source link

PM-12259: Use validatePin SDK to validate the users pin #4311

Closed david-livefront closed 1 week ago

david-livefront commented 1 week ago

🎟ī¸ Tracking

PM-12259

📔 Objective

This PR update the validatePin function in the AuthRepository to use the purpose-made SDK function to validate the pin. This fixes some bugs that can occur from calling the initializeCrypto function in unexpected places, which is how the previous logic worked.

⏰ Reminders before review

đŸĻŽ Reviewer guidelines

github-actions[bot] commented 1 week ago

Logo Checkmarx One – Scan Summary & Details – ac7d8f98-cd42-467a-9d6e-f39e5b012965

No New Or Fixed Issues Found

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.01%. Comparing base (1b0bc13) to head (fd6164e). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4311 +/- ## ========================================== - Coverage 89.01% 89.01% -0.01% ========================================== Files 453 453 Lines 39001 38992 -9 Branches 5488 5486 -2 ========================================== - Hits 34717 34708 -9 Misses 2375 2375 Partials 1909 1909 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

david-livefront commented 1 week ago

Thanks @dseverns-livefront