bitwarden / android

Bitwarden mobile app for Android.
https://bitwarden.com
GNU General Public License v3.0
6.55k stars 819 forks source link

PM-15025: Update sendVerificationEmail to handle error responses #4336

Closed david-livefront closed 2 days ago

david-livefront commented 3 days ago

🎟ī¸ Tracking

PM-15025

📔 Objective

This PR updates the sendVerificationEmail API to properly parse error messages from the server so they can be displayed to the user.

📸 Screenshots

Before After

⏰ Reminders before review

đŸĻŽ Reviewer guidelines

github-actions[bot] commented 3 days ago

Logo Checkmarx One – Scan Summary & Details – e7481d16-1400-4ab7-8009-08980a7e64f9

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt: 875 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /crowdin-pull.yml: 26
codecov[bot] commented 3 days ago

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.99%. Comparing base (d418444) to head (4945d10). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../datasource/network/service/IdentityServiceImpl.kt 87.50% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4336 +/- ## ======================================= Coverage 88.99% 88.99% ======================================= Files 453 453 Lines 39097 39109 +12 Branches 5510 5513 +3 ======================================= + Hits 34794 34805 +11 Misses 2377 2377 - Partials 1926 1927 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

david-livefront commented 2 days ago

Thanks @SaintPatrck