bitwarden / android

Bitwarden mobile app for Android.
https://bitwarden.com
GNU General Public License v3.0
6.55k stars 819 forks source link

PM-12733: Add error dialog to be displayed if TOTP code is blank #4345

Closed david-livefront closed 1 day ago

david-livefront commented 1 day ago

๐ŸŽŸ๏ธ Tracking

PM-12733

๐Ÿ“” Objective

This PR adds an error dialog to be displayed if the user attempts to enter a blank totp code.

โฐ Reminders before review

๐Ÿฆฎ Reviewer guidelines

github-actions[bot] commented 1 day ago

Logo Checkmarx One โ€“ Scan Summary & Details โ€“ 66ccde23-d59f-4e4e-84e5-eb51a9ca3a28

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt: 875 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /crowdin-pull.yml: 26
codecov[bot] commented 1 day ago

Codecov Report

Attention: Patch coverage is 85.71429% with 5 lines in your changes missing coverage. Please review.

Project coverage is 88.99%. Comparing base (3092ba1) to head (8937929). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...eature/manualcodeentry/ManualCodeEntryViewModel.kt 81.81% 3 Missing and 1 partial :warning:
...t/feature/manualcodeentry/ManualCodeEntryScreen.kt 92.30% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4345 +/- ## ======================================= Coverage 88.98% 88.99% ======================================= Files 452 452 Lines 39088 39120 +32 Branches 5513 5518 +5 ======================================= + Hits 34784 34814 +30 - Misses 2377 2378 +1 - Partials 1927 1928 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


๐Ÿšจ Try these New Features:

david-livefront commented 1 day ago

Thanks @dseverns-livefront