PM-15036 Show visual feedback for the send code on export vault.

dseverns-livefront commented 5 days ago

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-15036

📔 Objective

Show dialog and toast when sending OTP code for exporting vault.

📸 Screenshots

https://github.com/user-attachments/assets/38f56e01-761f-4546-81eb-c9064af87c0b

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

github-actions[bot] commented 5 days ago

Checkmarx One – Scan Summary & Details – 0adfcb3e-56f8-4475-aa88-1b4c241b8336

New Issues

Severity	Issue	Source File / Package	Checkmarx Insight
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt: 875	Attack Vector

Fixed Issues

Severity	Issue	Source File / Package
	Unpinned Actions Full Length Commit SHA	/crowdin-pull.yml: 26

codecov[bot] commented 5 days ago

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.99%. Comparing base (3092ba1) to head (df70880). Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
...ature/settings/exportvault/ExportVaultViewModel.kt	94.11%	0 Missing and 1 partial :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #4346 +/- ## ======================================= Coverage 88.98% 88.99% ======================================= Files 452 452 Lines 39088 39104 +16 Branches 5513 5516 +3 ======================================= + Hits 34784 34799 +15 Misses 2377 2377 - Partials 1927 1928 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests

bitwarden / android