PM-14963: Add toast when login via device succeeds

david-livefront commented 1 day ago

🎟️ Tracking

PM-14963

📔 Objective

This PR adds a toast when you successfully login with device.

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

github-actions[bot] commented 1 day ago

Checkmarx One – Scan Summary & Details – cc5e3ae0-e8f3-4687-9968-a6ea0b81e5a2

New Issues

Severity	Issue	Source File / Package	Checkmarx Insight
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt: 875	Attack Vector

Fixed Issues

Severity	Issue	Source File / Package
	Unpinned Actions Full Length Commit SHA	/crowdin-pull.yml: 26

david-livefront commented 1 day ago

Thanks @dseverns-livefront

codecov[bot] commented 1 day ago

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.00%. Comparing base (d4033a7) to head (998fee7). Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
...h/feature/loginwithdevice/LoginWithDeviceScreen.kt	50.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #4351 +/- ## ======================================= Coverage 89.00% 89.00% ======================================= Files 452 452 Lines 39155 39157 +2 Branches 5524 5524 ======================================= + Hits 34848 34852 +4 + Misses 2379 2377 -2 Partials 1928 1928 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests

bitwarden / android