bitwarden / android

Bitwarden mobile app for Android.
https://bitwarden.com
GNU General Public License v3.0
6.55k stars 819 forks source link

Refactor usage of the ContentCard to always use the ContentBlock component. #4357

Closed dseverns-livefront closed 21 hours ago

dseverns-livefront commented 22 hours ago

🎟️ Tracking

In support of the changes for https://bitwarden.atlassian.net/browse/PM-15067 and other design audits

📔 Objective

📸 Screenshots

⏰ Reminders before review

🦮 Reviewer guidelines

github-actions[bot] commented 22 hours ago

Logo Checkmarx One – Scan Summary & Detailsd6ddcf3f-023a-4264-a61e-3453e7e8385a

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt: 875 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /crowdin-pull.yml: 26
codecov[bot] commented 22 hours ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.00%. Comparing base (d418444) to head (19346b7). Report is 13 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4357 +/- ## ======================================= Coverage 88.99% 89.00% ======================================= Files 453 452 -1 Lines 39097 39076 -21 Branches 5510 5509 -1 ======================================= - Hits 34794 34778 -16 + Misses 2377 2372 -5 Partials 1926 1926 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: