bitwarden / android

Bitwarden mobile app for Android.
https://bitwarden.com
GNU General Public License v3.0
6.56k stars 821 forks source link

[PM-15057] Rename Fido2CredentialRequest to Fido2CreateCredentialRequest #4362

Closed SaintPatrck closed 3 days ago

SaintPatrck commented 4 days ago

šŸŽŸļø Tracking

PM-15057

šŸ“” Objective

Rename Fido2CredentialRequest to Fido2CreateCredentialRequest for clarity and consistency. This change reflects the specific purpose of the request, which is to create a new FIDO2 credential.

ā° Reminders before review

šŸ¦® Reviewer guidelines

github-actions[bot] commented 4 days ago

Logo Checkmarx One ā€“ Scan Summary & Details ā€“ bb55245c-b7dd-4db8-aea9-eb4e807d783f

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 346 Attack Vector
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 346 Attack Vector
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountViewModel.kt: 321 Attack Vector
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountViewModel.kt: 321 Attack Vector
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt: 875 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 341
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 341
MEDIUM Unpinned Actions Full Length Commit SHA /crowdin-pull.yml: 26
codecov[bot] commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.03%. Comparing base (1ef7e21) to head (0e9d068). Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4362 +/- ## ======================================= Coverage 89.03% 89.03% ======================================= Files 451 451 Lines 39135 39135 Branches 5523 5523 ======================================= Hits 34842 34842 Misses 2368 2368 Partials 1925 1925 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


šŸšØ Try these New Features: