Closed Elastic-Heart closed 1 month ago
Thank you for your contribution! We've added this to our internal Community PR board for review. ID: BWA-53
Checkmarx One â Scan Summary & Details â e9b7112d-e11a-4ae5-8a52-c035bec0c8c2
Attention: Patch coverage is 0%
with 7 lines
in your changes missing coverage. Please review.
Project coverage is 0.95%. Comparing base (
bcea5a6
) to head (7a074d0
). Report is 1 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
...uthenticator/feature/search/ItemSearchViewModel.kt | 0.00% | 5 Missing :warning: |
.../authenticator/feature/search/ItemSearchContent.kt | 0.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Changes have been approved. Thank you for your contribution, @Elastic-Heart.
@Elastic-Heart Could we get you to sign the CLA for this repository? We mistakenly did not have it configured properly when your PR was submitted. Unfortunately, we will need to remove the contribution if we don't get the CLA signed. Thanks!
@kspearrin done.
đī¸ Tracking
https://github.com/bitwarden/authenticator-android/issues/146
đ Objective
Fix a bug that prevented users from copying the code in the search screen. The behavior is now similar to the ItemListingScreen.
đ¸ Screenshots
â° Reminders before review
đĻŽ Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or âšī¸ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or đ (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or â ī¸ (:warning:
) for more significant problems or concerns needing attention:seedling:
) or âģī¸ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes