bitwarden / authenticator-android

Bitwarden Authenticator mobile app for Android.
https://bitwarden.com
GNU General Public License v3.0
324 stars 22 forks source link

[BWA-53] Fix: Resolve issue with code copying in search results #163

Closed Elastic-Heart closed 1 month ago

Elastic-Heart commented 1 month ago

🎟ī¸ Tracking

https://github.com/bitwarden/authenticator-android/issues/146

📔 Objective

Fix a bug that prevented users from copying the code in the search screen. The behavior is now similar to the ItemListingScreen.

📸 Screenshots

⏰ Reminders before review

đŸĻŽ Reviewer guidelines

bitwarden-bot commented 1 month ago

Thank you for your contribution! We've added this to our internal Community PR board for review. ID: BWA-53

github-actions[bot] commented 1 month ago

Logo Checkmarx One – Scan Summary & Details – e9b7112d-e11a-4ae5-8a52-c035bec0c8c2

No New Or Fixed Issues Found

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 0.95%. Comparing base (bcea5a6) to head (7a074d0). Report is 1 commits behind head on main.

Files Patch % Lines
...uthenticator/feature/search/ItemSearchViewModel.kt 0.00% 5 Missing :warning:
.../authenticator/feature/search/ItemSearchContent.kt 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #163 +/- ## ======================================== - Coverage 0.95% 0.95% -0.01% ======================================== Files 85 85 Lines 4307 4309 +2 Branches 475 475 ======================================== Hits 41 41 - Misses 4255 4257 +2 Partials 11 11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

SaintPatrck commented 1 month ago

Changes have been approved. Thank you for your contribution, @Elastic-Heart.

kspearrin commented 1 day ago

@Elastic-Heart Could we get you to sign the CLA for this repository? We mistakenly did not have it configured properly when your PR was submitted. Unfortunately, we will need to remove the contribution if we don't get the CLA signed. Thanks!

https://cla-assistant.io/bitwarden/authenticator-android

Elastic-Heart commented 1 day ago

@kspearrin done.