[BWA-57] Define feature flag disk source

SaintPatrck commented 2 months ago

🎟️ Tracking

https://bitwarden.atlassian.net/browse/BWA-57

📔 Objective

Define and implement FeatureFlagDiskSource for reading and storing feature flag states in SharedPreferences.

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

github-actions[bot] commented 2 months ago

Checkmarx One – Scan Summary & Details – b1223d15-d8ae-4dc4-a932-f6ebcb59f723

No New Or Fixed Issues Found

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 1.59%. Comparing base (3c74a34) to head (5ae9361). Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...tform/datasource/disk/FeatureFlagDiskSourceImpl.kt	90.90%	0 Missing and 1 partial :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #175 +/- ## ======================================== + Coverage 1.17% 1.59% +0.41% ======================================== Files 87 88 +1 Lines 4328 4339 +11 Branches 493 494 +1 ======================================== + Hits 51 69 +18 + Misses 4266 4258 -8 - Partials 11 12 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

SaintPatrck commented 2 months ago

⛏️ I see there are some tests missing by Codecov, but I'll leave it to you to see if they are worth enough to add or if they are in another PR.

Missing tests were from changes in the previous PR. They were added after this PR was created. Now that I've updated this branch we should have 100% coverage of these changes. 🥳

bitwarden / authenticator-android