bitwarden / authenticator-android

Bitwarden Authenticator mobile app for Android.
https://bitwarden.com
GNU General Public License v3.0
354 stars 24 forks source link

[BWA-61] Fix pre-existing detekt issues #179

Closed SaintPatrck closed 2 months ago

SaintPatrck commented 2 months ago

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/BWA-61

๐Ÿ“” Objective

Fix pre-existing detekt issues that ignored in the baseline file.

โฐ Reminders before review

๐Ÿฆฎ Reviewer guidelines

github-actions[bot] commented 2 months ago

Logo Checkmarx One โ€“ Scan Summary & Details โ€“ 3661afea-4af3-4a8a-b3b5-5c992d9ed48b

No New Or Fixed Issues Found

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 1.10497% with 179 lines in your changes missing coverage. Please review.

Project coverage is 2.31%. Comparing base (5758b34) to head (0318dd4). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...icator/feature/itemlisting/ItemListingViewModel.kt 0.00% 44 Missing :warning:
...i/authenticator/feature/edititem/EditItemScreen.kt 0.00% 21 Missing :warning:
...uthenticator/feature/edititem/EditItemViewModel.kt 0.00% 14 Missing :warning:
...enticator/feature/itemlisting/ItemListingScreen.kt 0.00% 9 Missing :warning:
...eature/manualcodeentry/ManualCodeEntryViewModel.kt 0.00% 9 Missing :warning:
...tor/ui/platform/feature/tutorial/TutorialScreen.kt 0.00% 9 Missing :warning:
...tor/ui/platform/feature/settings/SettingsScreen.kt 0.00% 8 Missing :warning:
...latform/feature/settings/export/ExportViewModel.kt 0.00% 7 Missing :warning:
...data/platform/manager/imports/ImportManagerImpl.kt 0.00% 5 Missing and 1 partial :warning:
...i/platform/feature/settings/export/ExportScreen.kt 0.00% 6 Missing :warning:
... and 21 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #179 +/- ## ======================================== + Coverage 2.30% 2.31% +0.01% ======================================== Files 90 90 Lines 4379 4357 -22 Branches 502 500 -2 ======================================== Hits 101 101 + Misses 4261 4239 -22 Partials 17 17 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.