bitwarden / authenticator-ios

Bitwarden Authenticator mobile app for iOS.
https://bitwarden.com
GNU General Public License v3.0
146 stars 8 forks source link

Show error alert when attempting to import a password-protected 2fas export #115

Closed KatherineInCode closed 5 months ago

KatherineInCode commented 5 months ago

📔 Objective

This updates the 2FAS import flow to detect if the user is trying to import a password-protected export, and provide an error alert if they do indicating we do not currently support that.

📸 Screenshots

Simulator Screenshot - iPhone 15 Pro - 2024-06-12 at 12 38 50

⏰ Reminders before review

đŸĻŽ Reviewer guidelines

github-actions[bot] commented 5 months ago

Logo Checkmarx One – Scan Summary & Details – 62a42459-1b9f-4bf5-aa77-7b96ca56a111

No New Or Fixed Issues Found

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 61.78%. Comparing base (1b5a279) to head (f273fb6).

Files Patch % Lines
...gs/Settings/ImportItems/ImportItemsProcessor.swift 0.00% 2 Missing :warning:
...ared/Core/Vault/Models/Enum/ImportFormatType.swift 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #115 +/- ## ========================================== - Coverage 62.36% 61.78% -0.58% ========================================== Files 199 199 Lines 6754 6754 ========================================== - Hits 4212 4173 -39 - Misses 2542 2581 +39 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.