bitwarden / authenticator-ios

Bitwarden Authenticator mobile app for iOS.
https://bitwarden.com
GNU General Public License v3.0
138 stars 7 forks source link

[BWA-39] Properly generate codes for search results #119

Closed KatherineInCode closed 1 week ago

KatherineInCode commented 3 months ago

๐ŸŽŸ๏ธ Tracking

BWA-39

๐Ÿ“” Objective

This fixes a bug where search results weren't generating/refreshing TOTP codes properly. This also backfills some tests.

๐Ÿ“ธ Screenshots

Simulator Screenshot - iPhone 15 Pro - 2024-06-13 at 15 43 14

โฐ Reminders before review

๐Ÿฆฎ Reviewer guidelines

github-actions[bot] commented 3 months ago

Logo Checkmarx One โ€“ Scan Summary & Details โ€“ 8694e7e3-3dac-453f-a448-8e6a5e07c692

No New Or Fixed Issues Found

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 86.20690% with 8 lines in your changes missing coverage. Please review.

Project coverage is 65.99%. Comparing base (4cfe64f) to head (e4459ef). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ared/Core/Platform/Services/ServiceContainer.swift 0.00% 4 Missing :warning:
...ult/Repositories/AuthenticatorItemRepository.swift 90.90% 3 Missing :warning:
...UI/Vault/ItemList/ItemList/ItemListProcessor.swift 94.73% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #119 +/- ## ========================================== + Coverage 63.37% 65.99% +2.61% ========================================== Files 202 202 Lines 8685 8698 +13 ========================================== + Hits 5504 5740 +236 + Misses 3181 2958 -223 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.