added hostname option to serve command - Githubissues

bitwarden / cli

The command line vault (Windows, macOS, & Linux).

https://bitwarden.com

GNU General Public License v3.0

1.62k stars 174 forks source link

added hostname option to serve command #519

Closed kspearrin closed 2 years ago

kspearrin commented 2 years ago

Type of change

[x] Bug fix
[ ] New feature development
[ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
[ ] Build/deploy pipeline (DevOps)
[ ] Other

Objective

Provide a way to bind a hostname to the serve webserver. Also, provide a secure default.

Resolves https://github.com/bitwarden/cli/issues/518

Code changes

serve.command.ts: Add hostname binding to koa's listen function, which starts a webserver. Default to localhost.
program.ts: Provide hostname option for serve and add docs to support it.

Testing requirements

Launch serve command with and without hostname binding to ensure that it is not accessible from alternate hostnames (unless using all value).

Before you submit

[x] I have checked for linting errors (npm run lint) (required)
[x] This change requires a documentation update (notify the documentation team)
[ ] This change has particular deployment requirements (notify the DevOps team)