bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
9.26k stars 1.24k forks source link

[Firefox extension] [Windows Desktop] [Web] Username generator with "Include number" now only generates single digit number #10388

Closed Tipoff4317 closed 1 month ago

Tipoff4317 commented 3 months ago

Steps To Reproduce

  1. Firefox extension
  2. Click Generator
  3. Click Username, Random word, Include number

Expected Result

A random word, plus 4-digit number, as in:

https://bitwarden.com/help/generator/

Actual Result

A random word, plus a single-digit number

Screenshots or Videos

The screenshot is from the web app:

Bitwarden 2024-08-04 041752

Additional Context

Same "problem" with:

  1. Firefox extension 2024.7.1
  2. Windows desktop app 2024.7.1
  3. Web app 2024.7.2

Operating System

Windows

Operating System Version

Windows 11 Pro 23H2

Web Browser

Firefox

Browser Version

128.0.1ESR

Build Version

2024.7.1

Issue Tracking Info

sammbw commented 2 months ago

Hi there,

Thank you for your report!

I was able to reproduce this issue, and I have flagged this to our engineering team.

If you wish to add any further information/screenshots/recordings etc., please feel free to do so at any time - our engineering team will be happy to review these.

Thanks once again!

eldergod1800 commented 2 months ago

Also happening on the Linux Appimage 2024.7.1. Attached SS. Screenshot from 2024-08-05 11-51-24 Screenshot from 2024-08-05 11-51-57

LZeugirdor commented 2 months ago

Can verify I'm also having this issue on windows desktop bitwarden 2024.7.1

bin-wang commented 1 month ago

@sammbw It seems this issue has been fixed. Can you confirm that?

sammbw commented 1 month ago

@bin-wang thanks for pointing this out - it looks like this was remedied here: https://github.com/bitwarden/clients/pull/10032

I can confirm it's working as expected in 2024.8.2 desktop for myself, as well as the 2024.8.1 Firefox extension.

I'm closing the issue as complete for now, but please feel free to comment if you see this occur again!

eldergod1800 commented 1 month ago

Yes it is working again in 22024.8.2 desktop appimage.