bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
9.21k stars 1.24k forks source link

Getting Auto-Fill Prompt for Non-Credential Fields #10753

Closed rhaley64 closed 1 month ago

rhaley64 commented 2 months ago

Steps To Reproduce

  1. Go to a website with text field
  2. Click on a non-credential text field (search box, etc)
  3. Get auto-fill prompt

Expected Result

No auto-fill prompt for non-credential/logon fields.

Actual Result

Auto-fill prompt displays with No Items to Show.

Screenshots or Videos

image image

Additional Context

Started experiencing the issue in 24.8.0. Confirmed on Firefox and Edge.

Operating System

Windows

Operating System Version

No response

Web Browser

Chrome, Microsoft Edge, Firefox

Browser Version

No response

Build Version

24.8.0

Issue Tracking Info

cagonzalezcs commented 2 months ago

@rhaley64 Thank you for this bug report.

Can you by chance post either the URL where these examples exist, or potentially the form markup that is used for these forms?

This will help us refine the logic that we use to validate where the inline menu is mean to to be placed. Your two images show examples where this is undesirable, but it's worth keeping in mind that we've expanded where the inline menu can appear to incorporate identity and card autofill suggestions. The menu isn't mean to appear within login field exclusively, but should appear in locations where it makes sense for it to appear (ie. where credit card or identity vault items would be filled).

rhaley64 commented 1 month ago

Form markup used in the first screenshot:

<form id="376c6c94-b81d-4449-a6e2-099d1d7331ec" class="whale-form css-998hwl ekd0h1w0" novalidate="" autocomplete="off" action="javascript:void(0);">

<div class="MuiFormControl-root MuiTextField-root form-field  css-i44wyl" style="grid-area: title; width: 100%;">
<label class="MuiFormLabel-root MuiInputLabel-root MuiInputLabel-formControl MuiInputLabel-animated MuiInputLabel-sizeSmall MuiInputLabel-outlined MuiFormLabel-colorPrimary MuiInputLabel-root MuiInputLabel-formControl MuiInputLabel-animated MuiInputLabel-sizeSmall MuiInputLabel-outlined css-1g9jgp3" data-shrink="false" for="WHALE_d90d83ea-ff91-450f-ab34-bd58660f5e3c" id="WHALE_d90d83ea-ff91-450f-ab34-bd58660f5e3c-label">Card name</label>
<div class="MuiInputBase-root MuiOutlinedInput-root MuiInputBase-colorPrimary MuiInputBase-formControl MuiInputBase-sizeSmall MuiInputBase-adornedEnd css-1obrc0r">
<input aria-invalid="false" id="WHALE_d90d83ea-ff91-450f-ab34-bd58660f5e3c" name="title" placeholder="" type="text" maxlength="64" class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputSizeSmall MuiInputBase-inputAdornedEnd css-3ieusv" value="">
<div class="MuiInputAdornment-root MuiInputAdornment-positionEnd MuiInputAdornment-outlined MuiInputAdornment-sizeSmall css-1nvf7g0">0 / 64</div><fieldset aria-hidden="true" class="MuiOutlinedInput-notchedOutline css-igs3ac">
<legend class="css-yjsfm1">
<span>Card name</span>
</legend>
</fieldset>
</div>
</div>
</form>

And this is for the text field in the second screenshot:

<div style="width: 132px;" class="GL4OBY5BHDI mm_textField">

<input value="" style="width: 132px;" type="text" class="GL4OBY5BGDI GL4OBY5BMCI" id="Company_Name-input" tabindex="0" placeholder="">
</div>

Thank you!

cchaz003 commented 1 month ago

I've been seeing this type of problem everywhere in Chrome recently. Random Bitwarden icons have been showing up in the weirdest places (often not even in a visible text box). I even had a big icon (2" square) show up in the top left corner on some of my networking equipment web pages (I think it was some ubiquiti edgerouter but I cant remember specifically). I'm not sure if this is the same issue or not but I've completely disabled the autofill menu for now.

In general I would prefer to only have the option for login autofill so perhaps having an option for that would be useful if it doesn't exist already.

cagonzalezcs commented 1 month ago

@cchaz003 Can you please give some specific website examples where the problem is appearing?

cchaz003 commented 1 month ago

These are all from some of my networking equipment. It seems like input field with "address" or "name" gets the menu for sure. But like I said I've been seeing the icon/menu pop up in random places. If I come across some really weird ones I'll document those too.

Screenshot 2024-08-28 at 14 27 46 Screenshot 2024-08-28 at 14 32 08 Screenshot 2024-08-28 at 14 29 29
whawn1 commented 1 month ago

Been a bother for a couple of weeks, now, on several sites. Here's another: https://wyofile.com/contradictory-reports-of-harmful-air-quality-raise-alarms-questions/
Clipboarder 2024 08 29-006

c3JpbmkK commented 1 month ago

Some more instances

  1. portal.azure.com (few blades where names are used)
  2. Argocd UI (in the name filter)
  3. Rfc editor (https://www.rfc-editor.org/ top right search box)
  4. https://toolbox.googleapps.com/apps/dig/ (name box
  5. https://whois.domaintools.com/ (domain or ip box)
  6. https://github.com/\<insert repository name>/settings/secrets/actions/new
roos-robert commented 1 month ago

Some more instances here as well (Swedish sites):

Tested on Edge.

lukbukkit commented 1 month ago

I'm also getting the autofill prompt for the Gmail "Search in emails" field. Tested on Safari with Bitwarden extension 2024.8.1.

LightningRocks commented 1 month ago

I'm still getting issues with autofill on a specific website https://www.animemusicquiz.com where in the dropdown, Bitwarden tries to use the answer box to fill credential data when I do not want the extension to do such a thing. I have to turn off autofill so that it does not get in the way. Tested on Microsoft Edge (all versions), Brave Browser Nightly and Firefox Nightly all with Bitwarden Extension 2024.8.1 . I did not have this issue with 2024.7.1 and have temporarily reverted to this as a result

Screenshot 2024-09-05 at 4 56 07 AM
whawn1 commented 1 month ago

Firefox BW v 2024.8.1 Still getting these on several sites: this one, just awhile ago: https://www.theguardian.com/us-news/article/2024/sep/05/first-thing-georgia-high-school-shooting-student-charged Clipboarder 2024 09 05-004 Should mention that it seems to interfere with the Firefox screen capture function. Several times got ot an error msg that 'something went wrong'. Had to use the Windows snipping tool.

LightningRocks commented 1 month ago

The new Browser version 2024.8.2 also did not help with my issue. Unfortunately I still don't know what the issue is

user56956 commented 1 month ago

I'm also having this problem on numerous websites. It's driving me crazy enough that I'm tempted to disable autofill completely.

roos-robert commented 1 month ago

Using version 2024.9.0 and this issue is not solved, something happened in the last 1-2 months that broke this system. For example, made a payment through some stripe integration yesterday on a website and Bitwarden continuously got in the way filling out billing details (no passwords whatsoever available on the page).

jsspen commented 1 month ago

@cagonzalezcs this is definitely not fixed.

rhaley64 commented 1 month ago

I can also confirm that I'm still having this issue on 2024.9.0.

f-o commented 1 month ago

Cross-referencing https://github.com/bitwarden/clients/issues/10941#issuecomment-2355732384. Issue persists.

cagonzalezcs commented 1 month ago

We have some code changes coming in the v2024.9.1 release happening this week that should help with the problems being reported in this thread. Please keep an eye out for that, and until then feel free to disable the inline menu if desired.

@f-o Your linked comment is a bit more nuanced in concern. I'll be responding to you in the thread above to keep context for the response in the same place.