Regression: overscroll when scrolling a very long list of Orgs and Collections

senpro-ingwersenk commented 3 weeks ago

Steps To Reproduce

Open the Bitwarden Desktop application
Observe a very long list of Organizations and Collections in the left side bar.
When scrolling down, you should now overshoot the main viewport of the screen and thus "overscroll

Screenshot: Screenshot moved into internal ticket and removed here by @djsmith85

Expected Result

I expected to not overscroll. This behaviour can sometimes unintentionally lead to mismatching with a scroll area list resulting in misalignments as well.

Actual Result

This refers to the commit a86768e which ment to fix this behaviour. Unfortunately, this issue is present again.

Upon scrolling down in either the left or center pane, an overscroll occurs.

This was apparently fixed once before: https://github.com/bitwarden/clients/runs/17054482431 Since this still - or again? - occurs, I marked it as a regression.

Screenshots or Videos

Above.

Additional Context

Windows 10, Selfhosted Vaultwarden (albeit probably irrelevant in this case), tested on this client version:

Version 2024.8.1 Shell 31.3.1 Renderer 126.0.6478.185 Node 20.15.1 Architecture x64

Operating System

Windows

Operating System Version

Microsoft Windows [Version 10.0.22631.4037]

Installation method

Direct Download (from bitwarden.com)

Build Version

2024.8.1

Issue Tracking Info

[X] I understand that work is tracked outside of GitHub. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.

EDIT: Fixed title; moved mentioned commit plus reference link into ticket body.

escape0707 commented 3 weeks ago

This is such an unsearchable issue title.

senpro-ingwersenk commented 3 weeks ago

I've never been great at naming things... Do you have a better title suggestion, by chance?

escape0707 commented 3 weeks ago

Since the mentioned commit "fixed overscroll issue", you could simply title this as "Regression: overscroll when scrolling a very long list of Organizations and Collections", then mention the commit in the body of your issue ticket.

I said the original title is quite unsearchable because I viewed the issue list and can't figure out if your issue is related to the problem I was facing at that time without opening this issue page at all. No hard feelings.

senpro-ingwersenk commented 3 weeks ago

That's fair enough - I'll change that real quick. Thank you for the feedback!

bitwarden / clients