bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
9.21k stars 1.24k forks source link

Auto-Fill / Auto-Suggest not working for Basic Auth (Login Modal) #1191

Open mikey32230 opened 4 years ago

mikey32230 commented 4 years ago

Auto-Fill / Auto-Suggest does not appear to work for logging into the generic login modal provided by browsers. Forgive me, I do not know the official wording or term for this type of login dialog box, but you can see what I mean via the screenshots below.

This type of login dialog is very common for typical household routers. For example, my router is a Netgear R7000 running Fresh Tomato 2020.1 K26ARM USB AIO-64K

This appears to be a mixed issue across desktop and mobile browsers.

image image image

URL: http://192.168.1.1 (or your router's IP / hostname) Browsers tested: Safari 13.0.5 (15608.5.11), Chrome 80.0.3987.149, iOS 13.4 (Mobile Safari) Extension Version: 1.43.4

bjinse commented 4 years ago

This type of login is called Basic Authentication. I can confirm this does not work in Safari for me either. Testable at: https://www.workwearwebshop.nl/bjinse/listData.php

tinyoverflow commented 4 years ago

In the new Microsoft Edge for Mac (Version 83.0.478.37) it actually detects saved credentials on Basic Auth, but it is unable to fill it: image

TobiasWenzel commented 3 years ago

I have the same problem that BW does not auto-fill the Basic Auth credentials, at least for certain web sites. I am using Firefox 86.0 64-bit on Windows 10 with the Bitwarden Extension. The server on which that happens is a Microsoft Azure DevOps Server, hosted on an internal server in our company:

image

Even if I manually create a login for that server (without a domain), BW doesn't auto-fill it. Maybe the problem is because for some reason it does not recognize it? At the time the Firefox dialog appears, the BW icon does not show any number.

However, when I cancel the authentication and the server's error message is displayed, then the BW icons correctly shows the number of found logins (1):

image

But when reloading the page, the dialog is still not being populated.

I already tried different URL match detections, but all the same. I also tried it with the fully-qualified domain, but same problem. Could it be related to http? That server is not set up with https.

For testing I tried the sites from #1427, both Basic and Digest authentication, and both work with BW. I really don't know what is the difference between our company server and the other and why the latter works and the company server doesn't...

denalena commented 3 years ago

I wonder if this is even possible to do for a browser extension? It'd be pretty neat for sure.

tgreer-bw commented 3 years ago

It should work if there is exactly 1 matching item/URI.

https://bitwarden.com/help/article/autofill-faqs/#q-can-bitwarden-auto-fill-a-basicnative-authentication-prompt

mikey32230 commented 3 years ago

It should work if there is exactly 1 matching item/URI.

https://bitwarden.com/help/article/autofill-faqs/#q-can-bitwarden-auto-fill-a-basicnative-authentication-prompt

It does not work, that’s why this issue is open.

TobiasWenzel commented 3 years ago

It should work if there is exactly 1 matching item/URI.

https://bitwarden.com/help/article/autofill-faqs/#q-can-bitwarden-auto-fill-a-basicnative-authentication-prompt

@tgreer-bw I don't know where you got this URL from, but at this time of viewing this web page, there is no section about basic authentication. There is just "auto-fill on a split login-workflow" and "auto-fill while using a physical keyboard on an iPad".

In my case I only had exactly one matching URL (see also my screenshot).

tgreer-bw commented 3 years ago

We've decided to start more docs on basic auth, new URL link:

https://bitwarden.com/help/article/basic-auth-autofill/

TobiasWenzel commented 3 years ago

Thanks for the link. Unfortunately it doesn't help me, my problem persists. Also with the launch icon, it does not auto-fill.

yuliu commented 3 years ago

Same here with the auto-fill for basic authentication with only 1 item detected. And there's more, the launch action won't get the password submitted either.

apuignav commented 3 years ago

I have the same problem on Chrome Version 94.0.4606.81 (Official Build) (x86_64) on macOS. 1 login detected + 2 cards. Nothing is getting autofilled.

Avrution commented 2 years ago

Had this issue for almost 3 years since first switching to bw from lastpass and brought it up with support. Would be great if this could be fixed one of these years. Not being able to access your passwords for things like router logins without first canceling the window and going to copy/paste the credentials really dissuades from using a good password at all.

I'm not sure why they cannot add an overlay button to select the vault/logins.

bitwarden-bot commented 2 years ago

Hi @mikey32230, We're cleaning up our repositories in preparation for a major reorganization. Issues from last year will be marked as stale and closed after two weeks. If you still need help, comment to let us know and we'll look into it. Thanks!

TobiasWenzel commented 2 years ago

I still have the problem, no change within a year.

mayanksha commented 1 year ago

Facing the same issue on Chrome Version 110.0.5481.100 (Official Build) (arm64). It's super annoying since I can see I have exactly 1 entry in BW...yet the basic auth forms don't get filled.

sira87 commented 1 year ago

The issue persists. Bitwarden can't autofill Basic Auth forms.

tinyoverflow commented 1 year ago

It works fine for me for months now (Firefox). It is important, that the domain listed for the entry matches the domain exactly. Iirc it doesn't work if there are multiple entries for the same domain.

mikey32230 commented 1 year ago

It works fine for me for months now (Firefox). It is important, that the domain listed for the entry matches the domain exactly. Iirc it doesn't work if there are multiple entries for the same domain.

OK, here is current state of issue for me:

Screenshot 2023-10-17 at 5 22 57 PM

mikey32230 commented 1 year ago

Whoops, didn't mean to close this...

sira87 commented 1 year ago

It works fine for me for months now (Firefox). It is important, that the domain listed for the entry matches the domain exactly. Iirc it doesn't work if there are multiple entries for the same domain.

I have 2 local addresses with the same IP but different ports:

Also, Bitwarden doesn't seem to differenciate URLs based on ports. If an URL is saved multiple times with different ports, they just appear as viable login data based on that URL, without considering the port as a discriminator.