codecov[bot]
commented
1 week ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 33.46%. Comparing base (
33f7643) to head (596885a). Report is 2 commits behind head on main.
:white_check_mark: All tests successful. No failed tests found.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #12033 +/- ## ========================================== - Coverage 33.47% 33.46% -0.01% ========================================== Files 2854 2854 Lines 89335 89335 Branches 17012 17012 ========================================== - Hits 29907 29900 -7 - Misses 57072 57079 +7 Partials 2356 2356 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
- JS Bundle Analysis - Avoid shipping oversized bundles
github-actions[bot]
Checkmarx One – Scan Summary & Details – 
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-14485
📔 Objective
Refactor the remaining logic from gulp.
Differences compared to #11861, escaped the arguments for
apps/browser/scripts/package-safari.ps1, since it's not done automatically by PowerShell.Part of the browser build script refactor effort. bitwarden.atlassian.net/browse/PM-6683
Webpack is now responsible for performing most of the operations previously done by gulp. This includes:
The
package.jsonis modified to include browser specific commands forbuild,build:prod,build:watchanddist.Manifests
Manifests now uses the
copy-webpack-plugintransformfeature. The logic is located inapps/browser/webpack/manifest.js. It reads a template, which supports some basic operations primarily overriding with browser specific fields using__browser__.The
manifest.jsonfor both regular and mv3 builds are identical to our existing manifests except:applicationsrenamed tobrowser_specific_settings.permissionssorted alphabetically.Safari build
Safari requires additional packaging commands. This is implemented as a powershell script due to the cross-platform nature, and since we generally require powershell in our distribution pipelines.
An alternative would be to write it in bash, but bash is less powerful and would require some additional commands like
jq. Another alternative is to write it using js, but that would require additional dependencies.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes