bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
9.36k stars 1.26k forks source link

Switch to using PowerShell for compressing #12052

Closed Hinton closed 6 days ago

Hinton commented 6 days ago

🎟ī¸ Tracking

📔 Objective

In #12033 we tried using tar for creating zip archives as a cross platform solution. Unfortunately this creates non windows compatible zip archives. As there is no command line tool available for zipping cross platform it's done using powershell as we already require it in multiple places.

⏰ Reminders before review

đŸĻŽ Reviewer guidelines

codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 33.48%. Comparing base (2185559) to head (9ce578b). Report is 1 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #12052 +/- ## ======================================= Coverage 33.48% 33.48% ======================================= Files 2855 2855 Lines 89360 89360 Branches 17016 17016 ======================================= Hits 29921 29921 Misses 57082 57082 Partials 2357 2357 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: