bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
9.36k stars 1.26k forks source link

Update bank account verification to use statement descriptor #12055

Closed amorask-bitwarden closed 5 days ago

amorask-bitwarden commented 6 days ago

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-15048

๐Ÿ“” Objective

Updates the bank account verification functionality behind the Stripe Sources API deprecation flag to use Stripe's updated statement descriptor verification approach.

๐Ÿ“ธ Screenshots

https://github.com/user-attachments/assets/cd820b28-3ce8-482d-ba26-69ad97f6bae8

โฐ Reminders before review

๐Ÿฆฎ Reviewer guidelines

codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 33.52%. Comparing base (2df8643) to head (2845f46). Report is 12 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...rify-bank-account/verify-bank-account.component.ts 0.00% 1 Missing :warning:
...ling/models/request/verify-bank-account.request.ts 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #12055 +/- ## ========================================== - Coverage 33.52% 33.52% -0.01% ========================================== Files 2859 2859 Lines 89434 89433 -1 Branches 17022 17022 ========================================== - Hits 29986 29979 -7 - Misses 57087 57093 +6 Partials 2361 2361 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


๐Ÿšจ Try these New Features:

github-actions[bot] commented 6 days ago

Logo Checkmarx One โ€“ Scan Summary & Details โ€“ c406891c-f7bf-4d8c-bff4-aef263581534

Fixed Issues

Severity Issue Source File / Package
LOW Client_JQuery_Deprecated_Symbols /apps/cli/src/service-container/service-container.ts: 876