Open cyprain-okeke opened 2 days ago
Attention: Patch coverage is 27.77778%
with 52 lines
in your changes missing coverage. Please review.
Project coverage is 33.41%. Comparing base (
e6c68b7
) to head (756c2a7
).
:white_check_mark: All tests successful. No failed tests found.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
๐จ Try these New Features:
Checkmarx One โ Scan Summary & Details โ 2fa07852-cac6-4195-b90a-6241c3955eb7
Severity | Issue | Source File / Package |
---|---|---|
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 101 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 101 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 101 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 101 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 76 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 76 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 76 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 76 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 76 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 76 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 76 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 76 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 76 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 76 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 76 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 76 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 76 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 76 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 76 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 76 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 76 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 76 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 76 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 76 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 76 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 76 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 76 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 76 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 76 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 76 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 76 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 76 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 76 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 76 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 76 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 76 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 76 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 76 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 76 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 76 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 101 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 101 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 101 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 101 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 101 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 101 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 101 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 101 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 101 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 101 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 101 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 101 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 101 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 101 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 101 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 101 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 101 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 101 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 101 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 101 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 101 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 101 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 101 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 76 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 101 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 101 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 101 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 101 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 101 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 101 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 101 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 101 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 101 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 101 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 101 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 76 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 76 | |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/view.component.ts: 101 | |
Client_DOM_Open_Redirect | /apps/desktop/src/auth/login/login-via-auth-request-v1.component.ts: 61 | |
Client_DOM_Open_Redirect | /apps/browser/src/auth/popup/login-via-auth-request-v1.component.ts: 53 | |
Client_DOM_Open_Redirect | /apps/desktop/src/auth/login/login-via-auth-request-v1.component.ts: 61 | |
Client_DOM_Open_Redirect | /apps/browser/src/auth/popup/login-via-auth-request-v1.component.ts: 53 |
๐๏ธ Tracking
https://bitwarden.atlassian.net/browse/PM-13347
๐ Objective
When the Remove Bitwarden Families policy is on, the product will follow the following behaviors depending on the # of organizations the user is part of.
Individual vault impacts - Scenario 1
Given the users email address is only associated with 1 enterprise organization, when the policy is turned on, then hide the Free Bitwarden Families page from the navigation
Individual vault impacts - Scenario 2
Given the email address is associated with multiple enterprise organization, the policy is turned on, and my sponsorship is status is active, when the user attempts to interact with the three dot menu, then the only option is to remove the sponsorship
Individual vault impacts - Scenario 3
Given the email address is associated with multiple enterprise organization, the policy is turned on, and my sponsorship is status is sent, when the user attempts to interact with the three dot menu, then the only option is to remove the sponsorship and we hide the Resend email option
๐ธ Screenshots
โฐ Reminders before review
๐ฆฎ Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or โน๏ธ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or ๐ญ (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or โ ๏ธ (:warning:
) for more significant problems or concerns needing attention:seedling:
) or โป๏ธ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes