bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
9.36k stars 1.26k forks source link

[PM-11360] Remove export permission for providers #12062

Closed eliykat closed 4 days ago

eliykat commented 6 days ago

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-11360

📔 Objective

Remove provider export permissions. Provider users will not have the ability to access an organization’s export tab or export a managed organization’s items.

Server PR: https://github.com/bitwarden/server/pull/5051

📸 Screenshots

⏰ Reminders before review

🦮 Reviewer guidelines

github-actions[bot] commented 6 days ago

Logo Checkmarx One – Scan Summary & Details87284dc1-1623-47fd-a13a-bd96053e76b7

Fixed Issues

Severity Issue Source File / Package
LOW Client_JQuery_Deprecated_Symbols /apps/cli/src/service-container/service-container.ts: 876
codecov[bot] commented 5 days ago

Codecov Report

Attention: Patch coverage is 11.62791% with 38 lines in your changes missing coverage. Please review.

Project coverage is 33.45%. Comparing base (34e20b7) to head (079d9b9). Report is 9 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...s/settings/organization-settings-routing.module.ts 0.00% 14 Missing :warning:
...nizations/layouts/organization-layout.component.ts 40.00% 6 Missing :warning:
...on/src/admin-console/models/domain/organization.ts 0.00% 6 Missing :warning:
libs/importer/src/components/import.component.ts 0.00% 5 Missing :warning:
...navigation-switcher/navigation-switcher.stories.ts 0.00% 3 Missing :warning:
...youts/product-switcher/product-switcher.stories.ts 0.00% 3 Missing :warning:
apps/cli/src/tools/import.command.ts 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #12062 +/- ## ======================================= Coverage 33.44% 33.45% ======================================= Files 2864 2864 Lines 89666 89667 +1 Branches 17067 17067 ======================================= + Hits 29988 29997 +9 + Misses 57317 57309 -8 Partials 2361 2361 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

eliykat commented 5 days ago

I had to fix some mocks used in Storybook. The remaining 1 story change is an unapproved change from main which I will chase up now, but is not caused by this PR.