[PM-13348] Browser Extension impacts on Free Bitwarden Family Policy

cyprain-okeke commented 5 days ago

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13348

📔 Objective

Given the users email address is only associated with 1 enterprise organization, when the policy is turned on, then hide the Free Bitwarden Families page from the navigation in the updated extension navigation (Settings > About > More from Bitwarden)

Design: Extension refresh

📸 Screenshots

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

codecov[bot] commented 5 days ago

Codecov Report

Attention: Patch coverage is 55.55556% with 12 lines in your changes missing coverage. Please review.

Project coverage is 33.48%. Comparing base (bb09121) to head (ed959ef). Report is 1 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...bout-page/more-from-bitwarden-page-v2.component.ts	0.00%	4 Missing :warning:
...s/about-page/more-from-bitwarden-page.component.ts	0.00%	4 Missing :warning:
...ps/browser/src/services/families-policy.service.ts	83.33%	0 Missing and 3 partials :warning:
...rc/admin-console/services/policy/policy.service.ts	0.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #12073 +/- ## ========================================== - Coverage 33.48% 33.48% -0.01% ========================================== Files 2876 2877 +1 Lines 89872 89899 +27 Branches 17104 17108 +4 ========================================== + Hits 30095 30103 +8 - Misses 57401 57417 +16 - Partials 2376 2379 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 5 days ago

Checkmarx One – Scan Summary & Details – 0e688cb2-daef-441d-a99e-c9f8719840b8

bitwarden / clients