bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
9.34k stars 1.26k forks source link

[PM-15106] - add loading state to risk insights #12078

Closed jaasen-livefront closed 1 day ago

jaasen-livefront commented 1 day ago

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-15106

📔 Objective

This PR adds a loading state to the "All applications" and "Critical Applications" tabs in the risk insights page.

📸 Screenshots

Screenshot 2024-11-20 at 4 39 42 PM

⏰ Reminders before review

🦮 Reviewer guidelines

codecov[bot] commented 1 day ago

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 33.43%. Comparing base (6b25515) to head (e52dca1). Report is 1 commits behind head on PM-13455.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ess-intelligence/applications-loading.component.ts 0.00% 5 Missing :warning:
.../access-intelligence/all-applications.component.ts 0.00% 1 Missing :warning:
...ss-intelligence/critical-applications.component.ts 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## PM-13455 #12078 +/- ## ============================================ - Coverage 33.44% 33.43% -0.01% ============================================ Files 2848 2844 -4 Lines 89159 89097 -62 Branches 16992 16990 -2 ============================================ - Hits 29818 29790 -28 + Misses 57002 56969 -33 + Partials 2339 2338 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: