[PM-15112] Fix missing i18n and block ssh key creation in web

quexten commented 4 days ago

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-15112

📔 Objective

Since web is still missing capabilities for generating keys, we detect if the add-edit component gets opened with the ssh-key cipher-type selected and force switch to login, so that we do not accidentally allow the user to create broken ssh key ciphers.

This wil be removed as soon as we can generate ssh keys via the sdk in web.

📸 Screenshots

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

codecov[bot] commented 4 days ago

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 33.42%. Comparing base (38c4eeb) to head (e70953b). Report is 13 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...c/app/vault/individual-vault/add-edit.component.ts	0.00%	3 Missing :warning:
...pp/vault/individual-vault/add-edit-v2.component.ts	0.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #12082 +/- ## ========================================== - Coverage 33.44% 33.42% -0.03% ========================================== Files 2864 2871 +7 Lines 89637 89818 +181 Branches 17067 17105 +38 ========================================== + Hits 29978 30019 +41 - Misses 57297 57437 +140 Partials 2362 2362 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

JS Bundle Analysis - Avoid shipping oversized bundles

github-actions[bot] commented 4 days ago

Checkmarx One – Scan Summary & Details – 4e98ea02-6822-4ac9-bf9a-ffdc7f661887

bitwarden / clients