bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
9.36k stars 1.26k forks source link

[PM-15148] Fix toggle entry not displaying correctly on non-English clients #12088

Closed djsmith85 closed 4 days ago

djsmith85 commented 4 days ago

🎟ī¸ Tracking

https://bitwarden.atlassian.net/browse/PM-15148

📔 Objective

Fix an issue with toggle group entry on password-generator not being displayed properly on non-English clients

📸 Screenshots

Before

image

After

image

⏰ Reminders before review

đŸĻŽ Reviewer guidelines

codecov[bot] commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 33.45%. Comparing base (5873f0e) to head (d8a090d). Report is 1 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #12088 +/- ## ======================================= Coverage 33.45% 33.45% ======================================= Files 2865 2865 Lines 89650 89650 Branches 17070 17070 ======================================= Hits 29993 29993 Misses 57295 57295 Partials 2362 2362 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

github-actions[bot] commented 4 days ago

Logo Checkmarx One – Scan Summary & Details – 3ccfb7fb-069d-462f-94c1-df40e792c5ba

Fixed Issues

Severity Issue Source File / Package
LOW Client_JQuery_Deprecated_Symbols /apps/cli/src/service-container/service-container.ts: 876